Skip to content

test: add unit, smoke tests for custom search command#1654

Closed
hetangmodi-crest wants to merge 8 commits intofeat/split-custom-search-commandfrom
tests/tests-for-custom-search-command
Closed

test: add unit, smoke tests for custom search command#1654
hetangmodi-crest wants to merge 8 commits intofeat/split-custom-search-commandfrom
tests/tests-for-custom-search-command

Conversation

@hetangmodi-crest
Copy link
Copy Markdown
Contributor

@hetangmodi-crest hetangmodi-crest commented Mar 21, 2025 •
edited
Loading

Issue number:
ADDON-76780

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

This PR contains the test cases for the custom search command feature.
Dev changes for custom search command : PR #1653

Changes

Smoke and unit test cases are respectively added for the feature of custom search command.

User experience

No change in User experience as this PR contains only test cases.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@hetangmodi-crest hetangmodi-crest added the tests Updates in test cases (unit, smoke, ui) label Mar 21, 2025
@hetangmodi-crest hetangmodi-crest self-assigned this Mar 21, 2025
This was referenced Mar 21, 2025
Closed
Closed
@hetangmodi-crest hetangmodi-crest changed the title tests: test cases for custom search command test: add unit, smoke tests for custom search command Mar 21, 2025
@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review March 21, 2025 15:05
@hetangmodi-crest hetangmodi-crest requested a review from a team as a code owner March 21, 2025 15:05
@hetangmodi-crest hetangmodi-crest mentioned this pull request Apr 1, 2025
Closed
13 tasks
@hetangmodi-crest
Copy link
Copy Markdown
Contributor Author

hetangmodi-crest commented Apr 16, 2025

Closing this PR as the following changes are covered in
PR #1693 : Contains base code for supporting custom search command.
PR #1694 : Contains logic and test cases for the generation of commands.conf.
PR #1695 : Contains logic and test cases for the generation of searchbnf.conf.
PR #1697 : Contains logic and test cases for the generation of Python files.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@artemrys artemrys Awaiting requested review from artemrys

@sgoral-splunk sgoral-splunk Awaiting requested review from sgoral-splunk

@kkedziak-splunk kkedziak-splunk Awaiting requested review from kkedziak-splunk

Assignees

@hetangmodi-crest hetangmodi-crest

Labels

size/XXL tests Updates in test cases (unit, smoke, ui)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hetangmodi-crest